Skip to content

salt: T8973: remove feature - #5262

Merged
sever-sever merged 1 commit into
vyos:rollingfrom
c-po:remote-salt
Jun 10, 2026
Merged

salt: T8973: remove feature#5262
sever-sever merged 1 commit into
vyos:rollingfrom
c-po:remote-salt

Conversation

@c-po

@c-po c-po commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Change summary

As salt has been marked deprecated via T8056 and is thus deprecated in VyOS 1.5 and VyOS 1.4 it is time to remove it from the rolling release.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): Feature removal due to deprecation

Related Task(s)

Related PR(s)

How to test / Smoketest result

Embedded smoketest platform has a migration script

DEBUG - ok
DEBUG - test_vrf_bgp_pppoe_underlay (__main__.TestConfigVrfBgpPppoeUnderlay.test_vrf_bgp_pppoe_underlay) ...  time: 30.985
DEBUG - ok
DEBUG - test_vrf_ospf (__main__.TestConfigVrfOspf.test_vrf_ospf) ...  time: 23.493
DEBUG - ok
DEBUG - test_wireless_basic (__main__.TestConfigWirelessBasic.test_wireless_basic) ...  time: 7.111
DEBUG - ok
DEBUG -
DEBUG - ----------------------------------------------------------------------
DEBUG - Ran 51 tests in 1115.507s
DEBUG -
DEBUG - OK
DEBUG - vyos@vyos:~$ echo EXITCODE:$?
DEBUG - echo EXITCODE:$?
 INFO - Configtest finished successfully!
 INFO - Powering off system
poweroff nowCODE:0
 INFO - Shutting down virtual machine
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - Waiting for shutdown...
DEBUG - poweroff now
 INFO - VM is shut down!
 INFO - Cleaning up
 INFO - Removing disk file: testinstall-20260609-192856-38f1.raw

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
salt: T8973: remove feature
ba60d0c 
As salt has been marked deprecated via T8056 and is thus deprecated in VyOS 1.5
and VyOS 1.4 it is time to remove it from the rolling release.
@coderabbitai

coderabbitai Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

This PR removes the Salt minion service integration from VyOS. The system version increments to 33 with a migration that deletes existing service/salt-minion configurations. Supporting changes remove the salt-minion package dependency and the minion system user from the Debian package.

Changes

Salt minion service removal

Layer / File(s) Summary
System version migration and config removal
interface-definitions/include/version/system-version.xml.i, src/migration-scripts/system/32-to-33		 System version bumped to 33; migration logic simplified to delete entire service/salt-minion subtree when present, replacing prior per-node deletions and hash_type→hash / mine_interval→interval renames.
Debian package and system user cleanup
debian/control, debian/vyos-1x.postinst		 Removed salt-minion package dependency and minion system user creation from post-install script.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed Title clearly describes the main change: removing the salt feature due to deprecation (T8973).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description check ✅ Passed PR description clearly explains salt removal due to deprecation (T8056, T8973) with detailed change summary and testing results.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

github-actions Bot commented Jun 9, 2026 •
edited
Loading

Copy link
Copy Markdown

❌ Typos detected in PR (1 found)

File Typo Suggestion
debian/control:383 nd and

@mergify mergify Bot added the rolling label Jun 9, 2026
@mergify mergify Bot assigned c-po Jun 9, 2026
@c-po c-po mentioned this pull request Jun 9, 2026
Merged
11 tasks
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • CLI Smoketests VPP 👍 passed
  • Config tests VPP 👍 passed
  • TPM tests 👍 passed

sever-sever
sever-sever approved these changes Jun 10, 2026
View reviewed changes

@sever-sever sever-sever left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We agreed.to remove deprecated salt-minion feature.

natali-rs1985
natali-rs1985 approved these changes Jun 10, 2026
View reviewed changes

@natali-rs1985 natali-rs1985 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove deprecated salt-minion support

@sever-sever
sever-sever merged commit e165fdf into vyos:rolling Jun 10, 2026
24 checks passed
@vyos-bot vyos-bot Bot added mirror-initiated This PR initiated for mirror sync workflow mirror-completed and removed mirror-initiated This PR initiated for mirror sync workflow labels Jun 10, 2026
@c-po
c-po deleted the remote-salt branch June 19, 2026 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sever-sever sever-sever sever-sever approved these changes
@natali-rs1985 natali-rs1985 natali-rs1985 approved these changes
@dmbaturin dmbaturin Awaiting requested review from dmbaturin
@jestabro jestabro Awaiting requested review from jestabro

Assignees

@c-po c-po

Labels

mirror-completed rolling

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@c-po @sever-sever @natali-rs1985